267 make server more secure #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Wolkenfarmer
force-pushed
the
267-making-the-server-more-secure
branch
from
c5bc103 to
46b4daa
Compare
Wolkenfarmer
force-pushed
the
267-making-the-server-more-secure
branch
2 times, most recently
from
1262f76 to
1af4860
Compare
# Conflicts: # backend/dps_training_k/deployment/django/entrypoint
Wolkenfarmer
force-pushed
the
267-making-the-server-more-secure
branch
6 times, most recently
from
4d0ee5a to
973acc7
Compare
Wolkenfarmer
force-pushed
the
267-making-the-server-more-secure
branch
from
973acc7 to
db75b47
Compare
Wolkenfarmer
force-pushed
the
267-making-the-server-more-secure
branch
from
5504b5c to
90aa68a
Compare
Wolkenfarmer
force-pushed
the
267-making-the-server-more-secure
branch
from
90aa68a to
e66f708
Compare
Wolkenfarmer
force-pushed
the
267-making-the-server-more-secure
branch
from
7e22177 to
7f52a08
Compare
Wolkenfarmer
approved these changes
Jul 11, 2024
README.md
Outdated
| @@ -43,7 +43,7 @@ The application is now deployed and the website should be accessible on port 517 | |||
| the containers restarted accordingly. | |||
|
|
|||
| Keep in mind that the IP address of the server running the back- and frontend are hardcoded in the environment files. For | |||
| the backend a simple correction of the `FRONTEND_URL` variable within the `.env.<prod/dev>` file on the server is enough, but fot the frontend the | |||
| the backend a simple correction of the `FRONTEND_URL` variable within the `.env.<prod/dev>` file on the server is enough, but for the frontend the | |||
There was a problem hiding this comment.
Quite a few things have to be adjusted in the documentation now due to the changes you made. However, it is better to adjust them directly on the #290 branch as there is a major rework in place there already
Wuff
Wolkenfarmer
approved these changes
Jul 11, 2024
|
And please tidy up our serverm thank's <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.