Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat ecl docs #431

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Chat ecl docs #431

merged 1 commit into from
Aug 23, 2024

Conversation

GordonSmith
Copy link
Member

This is dependent on #429 so may be easier if that is merged first...

@GordonSmith GordonSmith requested a review from jeclrsg August 21, 2024 11:53
@GordonSmith GordonSmith force-pushed the CHAT_ECL_DOCS branch 2 times, most recently from 9cbf29a to 63dcfdc Compare August 22, 2024 19:01
Copy link
Collaborator

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith Approved. Didn't spot anything that seemed important. Made a note on index.ts

});
});

return topicsNoRepetition[Math.floor(Math.random() * topicsNoRepetition.length)] || "I have taught you everything I know. Meow!";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a handful of lingering references to cats in this file

@GordonSmith GordonSmith merged commit 32ba7fe into hpcc-systems:trunk Aug 23, 2024
1 check passed
@GordonSmith GordonSmith deleted the CHAT_ECL_DOCS branch August 23, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants