HPCC4J-657 DFSClient: Reading indices with blobs fails #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-657 Jirabot Action Result: |
jpmcmu
changed the title
drealeed
reviewed
Oct 24, 2024
| // if (field.isBlob()) | ||
| // { | ||
| // field.setIsBlob(false); | ||
| // } | ||
| } |
There was a problem hiding this comment.
is this commented out code needed?
There was a problem hiding this comment.
Yep, I have commented it back in as part of the subsequent commit
jpmcmu
changed the title
jpmcmu
commented
Oct 28, 2024
| @@ -260,6 +260,27 @@ public void biasedIntTest() throws Exception | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Note: This test will fail until HPCC-32875 is resolved
- Updated RecordDefinitionTranslator to maintain blob information - Added isBlob property to FieldDef - Added translation test for indices with blobs - Added index read test for indices with blobs - Updated data generation to create an index with blobs Signed-off-by: James McMullan [email protected]
|
@rpastrana wrapped up testing and squashed |
rpastrana
reviewed
Oct 29, 2024
commons-hpcc/src/main/java/org/hpccsystems/commons/ecl/RecordDefinitionTranslator.java
Show resolved
Hide resolved
|
Jirabot Action Result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: