Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-642 DFSClient FileUtilityTest failing due to credential prompting #751

Merged
merged 1 commit into from
Dec 16, 2024
Merged

HPCC4J-642 DFSClient FileUtilityTest failing due to credential prompting #751

merged 1 commit into from
Dec 16, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Sep 12, 2024

  • Added a non-interactive flag to FileUtility
  • Updated FileUtilityTest to use the non-interactive flag

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-642

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@jpmcmu jpmcmu changed the title HPCC4J-642 DFSClient FileUtilityTest failing due to credential prompting WIP: HPCC4J-642 DFSClient FileUtilityTest failing due to credential prompting Sep 23, 2024
@jpmcmu jpmcmu changed the base branch from candidate-9.6.x to candidate-9.8.x December 16, 2024 14:24
@jpmcmu jpmcmu closed this Dec 16, 2024
@jpmcmu jpmcmu reopened this Dec 16, 2024
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-642

Jirabot Action Result:
Workflow Transition To: Merge Pending

@jpmcmu
HPCC4J-642 DFSClient FileUtilityTest failing due to credential prompting
5e4b4e4 
- Added a non-interactive flag to FileUtility
- Updated FileUtilityTest to use the non-interactive flag

Signed-off-by: James McMullan [email protected]
@jpmcmu jpmcmu changed the base branch from candidate-9.8.x to candidate-9.6.x December 16, 2024 18:40
@jpmcmu jpmcmu requested a review from rpastrana December 16, 2024 18:40
@jpmcmu jpmcmu changed the title WIP: HPCC4J-642 DFSClient FileUtilityTest failing due to credential prompting HPCC4J-642 DFSClient FileUtilityTest failing due to credential prompting Dec 16, 2024
@jpmcmu
Copy link
Contributor Author

jpmcmu commented Dec 16, 2024

@rpastrana ready for review

rpastrana
rpastrana reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu seems fine, but is this only avoiding the interactive prompt? Last I heard the creds were not populated from the github vars/secrets.

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Dec 16, 2024

@rpastrana That was the problem with HPCC4J-594, the issue with this PR was a null exception. Due to non_interactive not being passed along to copy sub-operations.

@rpastrana rpastrana merged commit 85161dd into hpcc-systems:candidate-9.6.x Dec 16, 2024
@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.6.72
Added fix version: 9.8.46
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana