Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC4J-620 Jirabot: Sanitize information coming from external sources #720

Merged
merged 1 commit into from
Jul 3, 2024
Merged

HPCC4J-620 Jirabot: Sanitize information coming from external sources #720

merged 1 commit into from
Jul 3, 2024

Conversation

jpmcmu
Copy link
Contributor

@jpmcmu jpmcmu commented Jul 3, 2024

  • Removed code that printed out untrusted information
  • Modified curl command to use more secure subprocess module

Signed-off-by: James McMullan [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).

Checklist:

  • I have created a corresponding JIRA ticket for this submission
  • My code follows the code style of this project.
    • I have applied the Eclipse code-format template provided.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the HPCC Systems CONTRIBUTORS document (https://github.com/hpcc-systems/HPCC-Platform/wiki/Guide-for-contributors).
  • The change has been fully tested:
    • This change does not cause any existing JUnits to fail.
    • I have include JUnit coverage to test this change
    • I have performed system test and covered possible regressions and side effects.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • This change fixes the problem, not just the symptom

Testing:

@jpmcmu jpmcmu requested a review from rpastrana July 3, 2024 12:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Jira Issue: https://hpccsystems.atlassian.net/browse/HPCC4J-620

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

rpastrana
rpastrana reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, but for bookeeping, it was decided emails would be sanitized via standard api/regex. If no efficient way to do this is quickly identified, we'll stop reporting emails in logs until a later fix.

@jpmcmu
Copy link
Contributor Author

jpmcmu commented Jul 3, 2024

@rpastrana Added code to handle email sanitization

rpastrana
rpastrana reviewed Jul 3, 2024
View reviewed changes
.github/workflows/Jirabot.yml Outdated
# Return the email address only, returns '' if not valid or found
return parseaddr(input)[1]
else:
return input
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be considered a false positive, considering we don't know what format the input represents, it should return '' or an outright failure since email type is the only supported format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@jpmcmu
HPCC4J-620: Jirabot: Sanitize information coming from external sources
bb27667 
- Removed code that printed out untrusted information
- Modified curl command to use more secure subprocess module

Signed-off-by: James McMullan [email protected]
rpastrana
rpastrana approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@rpastrana rpastrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmcmu approved

@rpastrana rpastrana merged commit cf7c92f into hpcc-systems:candidate-9.2.x Jul 3, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpastrana rpastrana rpastrana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcmu @rpastrana