HPCC4J-562 Odd unsigned decimals incorrect scale #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rpastrana please review. @jchambers-ln @drealeed FYI |
rpastrana
reviewed
Dec 13, 2023
| self.udec16 := (REAL)(random() % unique_values); | ||
| self.udec15 := (REAL)(random() % unique_values); |
There was a problem hiding this comment.
Is there a corresponding test to verify these odd len decimals are correctly read?
There was a problem hiding this comment.
@rpastrana Yes, tests in DFSReadWriteTest read those generated datasets, write them back, and then compare the datasets against the generated datasets for correctness.
| @@ -830,7 +830,11 @@ private BigDecimal getUnsignedDecimal(int numDigits, int precision, int dataLen) | |||
| BigDecimal ret = new BigDecimal(0); | |||
|
|
|||
| int idx = 0; | |||
| int curDigit = numDigits - 1; | |||
| int curDigit = numDigits; | |||
| if ((numDigits % 2) == 0) | |||
There was a problem hiding this comment.
It's not entirely obvious to me why this logic is needed, perhaps an inline comment?
There was a problem hiding this comment.
Good point, added a comment and squashed
- Corrected BinaryRecordReader unsigned decimal parse code - Updated ECL test datasets to include odd precision decimal values Signed-off-by: James McMullan [email protected]
rpastrana
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James McMullan [email protected]
Type of change:
Checklist:
Testing: