Merge pull request #291 from GordonSmith/OSSAR_FAILING

fix:  Ossar tests failing with new eslint file format

.github/workflows/codeql-analysis.yml

@@ -39,7 +39,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v2
+        uses: github/codeql-action/init@v3
         with:
           languages: ${{ matrix.language }}
           # If you wish to specify custom queries, you can do so here or in a config file.
@@ -50,7 +50,7 @@ jobs:
       # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below)
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v2
+        uses: github/codeql-action/autobuild@v3
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 https://git.io/JvXDl
@@ -64,4 +64,5 @@ jobs:
       #   make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@v3
+

eslint.config.js

@@ -2,16 +2,17 @@ import globals from "globals";
 import pluginJs from "@eslint/js";
 import tseslint from "typescript-eslint";
 
+
+/** @type {import('eslint').Linter.Config[]} */
 export default [
     {
-        files: ["**/*.{js,mjs,cjs,ts}"],
+        files: [
+            "**/*.{js,mjs,cjs,ts}"
+        ]
     },
     {
         languageOptions: {
-            globals: {
-                ...globals.browser,
-                ...globals.node
-            }
+            globals: globals.browser
         }
     },
     pluginJs.configs.recommended,
@@ -20,15 +21,15 @@ export default [
         rules: {
             "@typescript-eslint/no-explicit-any": "off",
             "@typescript-eslint/no-unused-expressions": "off",
-            "@typescript-eslint/no-namespace": "off",
             "@typescript-eslint/no-unused-vars": [
-                "error", // or "error"
+                "error",
                 {
-                    "argsIgnorePattern": "^_",
-                    // "varsIgnorePattern": "^_",
-                    // "caughtErrorsIgnorePattern": "^_"
+                    "args": "none",
+                    "varsIgnorePattern": "^_"
                 }
-            ]
+            ],
+            "@typescript-eslint/no-namespace": "off",
         }
-    },
+    }
+
 ];

package.json

@@ -89,7 +89,7 @@
     "chokidar-cli": "3.0.0",
     "eslint": "9.16.0",
     "globals": "15.13.0",
-    "happy-dom": "^15.11.7",
+    "happy-dom": "15.11.7",
     "lerna": "8.1.9",
     "npm-run-all": "4.1.5",
     "playwright": "1.49.1",

packages/expat/src/expat.ts

@@ -144,7 +144,7 @@ export class StackParser implements IParser {
         return retVal;
     }
 
-    endElement(_tag: string): StackElement {
+    endElement(tag: string): StackElement {
         return this._stack.pop()!;
     }