Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove extraneous packages #4305

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: Remove extraneous packages #4305

merged 1 commit into from
Nov 20, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Nov 19, 2024 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg November 19, 2024 11:27
@GordonSmith GordonSmith force-pushed the DROP_UNUSED branch 6 times, most recently from bfc42f8 to fe5926c Compare November 19, 2024 13:07
jeclrsg
jeclrsg reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith couple of svg logos got included in the commit

demos/gallery/public/vite.svg Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be excluded?

demos/gallery/src/assets/react.svg Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be excluded?

demos/gallery/samples/chart/Contour/Basic.js Outdated
@@ -2,6 +2,8 @@ import { range as d3Range } from "@hpcc-js/common";
import { Contour } from "@hpcc-js/chart";
import { randomNormal as d3RandomNormal } from "d3-random";

debugger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugger statement here

@GordonSmith GordonSmith merged commit 19747ba into hpcc-systems:candidate-3.x.x Nov 20, 2024
4 checks passed
@GordonSmith GordonSmith deleted the DROP_UNUSED branch November 20, 2024 09:51
GordonSmith added a commit that referenced this pull request Nov 20, 2024
@GordonSmith
Merge pull request #4305 from GordonSmith/DROP_UNUSED
5836f05 
chore: Remove extraneous packages
GordonSmith added a commit that referenced this pull request Nov 20, 2024
@GordonSmith
Merge pull request #4305 from GordonSmith/DROP_UNUSED
afcc98a 
chore: Remove extraneous packages
GordonSmith added a commit that referenced this pull request Nov 20, 2024
@GordonSmith
Merge pull request #4305 from GordonSmith/DROP_UNUSED
3745112 
chore: Remove extraneous packages
GordonSmith added a commit to GordonSmith/Visualization that referenced this pull request Nov 20, 2024
@GordonSmith
Merge pull request hpcc-systems#4305 from GordonSmith/DROP_UNUSED
750b470 
chore: Remove extraneous packages
GordonSmith added a commit that referenced this pull request Nov 20, 2024
@GordonSmith
Merge pull request #4305 from GordonSmith/DROP_UNUSED
a74c058 
chore: Remove extraneous packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg