Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade map-deck to v3 #4294

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat: Upgrade map-deck to v3 #4294

merged 1 commit into from
Nov 13, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Nov 13, 2024 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg November 13, 2024 11:05
jeclrsg
jeclrsg approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith approved, noticed just a couple minor things, one maybe extra configuration in the launch.json & some commented out / unused imports in index.html

packages/map-deck/.vscode/launch.json Outdated
]
},
{
"name": "wsl index.html",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this config hasn't been in the others I don't believe

packages/map-deck/index.html Outdated
Comment on lines 59 to 62
// import "@hpcc-js/common/dist/index.css";
// import "@hpcc-js/common/font-awesome/css/font-awesome.min.css";
// import "@hpcc-js/chart/dist/index.css";
// import "@hpcc-js/dgrid2/dist/index.css";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some commented out imports here

@GordonSmith
feat: Upgrade map-deck to v3
22f7c15 
Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith merged commit 53e7c0e into hpcc-systems:candidate-3.x.x Nov 13, 2024
4 checks passed
@GordonSmith GordonSmith deleted the V3_DECK branch November 13, 2024 16:07
GordonSmith added a commit to GordonSmith/Visualization that referenced this pull request Nov 13, 2024
@GordonSmith
Merge pull request hpcc-systems#4294 from GordonSmith/V3_DECK
9a61f0f 
feat: Upgrade map-deck to v3
GordonSmith added a commit that referenced this pull request Nov 13, 2024
@GordonSmith
Merge pull request #4294 from GordonSmith/V3_DECK
c863c60 
feat: Upgrade map-deck to v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg