Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade graph, html and react to v3 #4285

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat: Upgrade graph, html and react to v3 #4285

merged 1 commit into from
Nov 11, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Nov 9, 2024 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg November 9, 2024 10:23
@GordonSmith GordonSmith force-pushed the V3_GRAPH branch 2 times, most recently from 9f7cc12 to 699ab93 Compare November 11, 2024 08:46
jeclrsg
jeclrsg approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith noticed one typo in a variable name, would approve otherwise

packages/react/src/text.tsx Outdated
}) => {

const [acutalWidth, setActualWidthUpdate] = React.useState(width);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo acutalWidth -> actualWidth

@GordonSmith GordonSmith force-pushed the V3_GRAPH branch 3 times, most recently from 567d794 to f95e990 Compare November 11, 2024 17:30
@GordonSmith GordonSmith merged commit b5bb00d into hpcc-systems:candidate-3.x.x Nov 11, 2024
4 checks passed
@GordonSmith GordonSmith deleted the V3_GRAPH branch November 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg