Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4219 Comms Layer for WsSasha Added #4220

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

kunalaswani
Copy link
Contributor

@kunalaswani kunalaswani commented Jul 30, 2024

Added WsSasha Service to comms layer.

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@kunalaswani
Copy link
Contributor Author

@GordonSmith please review

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, two things:

  1. The commit message adheres to "conventional commit msgs", which in turn auto creates the next version number and generates a log entry, for this PR it would look like:
feat(comms):  Add support for WsSasha

Fixes #xxx...

Signed...
  1. Could you add some tests to tests/test-comms/src/services

Fixes hpcc-systems#4219 Comms Layer for WsSasha Added

Signed-off-by: Kunal Aswani <[email protected]>
@GordonSmith GordonSmith merged commit a1ed8aa into hpcc-systems:trunk Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants