fix(comms): GetLogs use WsLogaccess.LogAccessType for filters #4213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the fields returned by WsLogaccess.GetLogAccessInfo exist in WsLogaccess.LogAccessType, have the filter use those categories, otherwise use the field defined by the log engine in the column map. This is a preliminary attempt at support for the Grafana Loki engine. Also, fixes an issue where searching by container name wouldn't return any log messages for ephemeral containers, eg "hthor-job-W2024..." as well as "hthor" Signed-off-by: Jeremy Clements <[email protected]>
GordonSmith
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the fields returned by WsLogaccess.GetLogAccessInfo exist in WsLogaccess.LogAccessType, have the filter use those categories, otherwise use the field defined by the log engine in the column map.
This is a preliminary attempt at support for the Grafana Loki engine.
Also, fixes an issue where searching by container name wouldn't return any log messages for ephemeral containers, eg "hthor-job-W2024..." as well as "hthor"
Checklist:
Testing: