Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comms): WsMachine Target Cluster sizes are in KB #4182

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(comms): WsMachine Target Cluster sizes are in KB #4182

merged 1 commit into from
Mar 21, 2024

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Mar 20, 2024

ESP typically returns any sizes in bytes, but WsMachine returns these disk usage sizes in kilobytes, so multiply by 1024.

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@jeclrsg
fix(comms): WsMachine Target Cluster sizes are in KB
0205f84 
ESP typically returns any sizes in bytes, but WsMachine returns these
disk usage sizes in kilobytes, so multiply by 1024.

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg requested a review from GordonSmith March 20, 2024 19:59
@GordonSmith GordonSmith merged commit 4514085 into hpcc-systems:trunk Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeclrsg @GordonSmith