Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parse the DefinitionList at source #4156

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 19, 2024

Ensure there are always "some" values for TimeLocalExecute

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg January 19, 2024 16:50
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith maybe a small problem in that regex? Not sure, tbh. I think it works either way.

packages/comms/src/ecl/workunit.ts Outdated Show resolved Hide resolved
@GordonSmith GordonSmith marked this pull request as draft January 22, 2024 15:58
@GordonSmith
Copy link
Member Author

@jeclrsg converting to draft as there are some more changes that should go in here...

@GordonSmith GordonSmith force-pushed the WU_DETAILS_DEFLIST branch 2 times, most recently from 5008e08 to 102cabe Compare January 23, 2024 09:58
Ensure there are always "some" values for TimeLocalExecute
Group properties at source

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith marked this pull request as ready for review January 23, 2024 13:39
@GordonSmith GordonSmith requested a review from jeclrsg January 23, 2024 13:39
@GordonSmith GordonSmith merged commit 95628fc into hpcc-systems:trunk Jan 23, 2024
5 checks passed
@GordonSmith GordonSmith deleted the WU_DETAILS_DEFLIST branch July 18, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants