Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add "LayoutChanged" event to DockPanel #4146

Merged
merged 1 commit into from
Jan 2, 2024
Merged

feat: Add "LayoutChanged" event to DockPanel #4146

merged 1 commit into from
Jan 2, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Dec 20, 2023 •
edited
Loading

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg December 20, 2023 18:50
@GordonSmith GordonSmith force-pushed the DOCKPANEL_LAYOUTCHANGED branch from 1b8dfd2 to 98e5f42 Compare December 20, 2023 18:55
GordonSmith
GordonSmith commented Dec 20, 2023
View reviewed changes
packages/phosphor/src/DockPanel.ts Outdated
@@ -145,25 +145,36 @@ export class DockPanel extends HTMLWidget implements IMessageHandler, IMessageHo
return true;
}

_lazyLayoutChanged = Utility.debounce(async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be private

@GordonSmith GordonSmith merged commit d74ebba into hpcc-systems:trunk Jan 2, 2024
5 checks passed
@GordonSmith GordonSmith deleted the DOCKPANEL_LAYOUTCHANGED branch January 2, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg