fix(html/common): correct BreakdownTable tooltip height calculation #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeclrsg
force-pushed
the
BreakdownTable-tooltip-height
branch
from
cb60419 to
c73fb2a
Compare
jeclrsg
changed the title
jeclrsg
commented
Nov 3, 2023
jeclrsg
commented
Nov 3, 2023
jeclrsg
commented
Nov 3, 2023
packages/common/src/Utility.ts
Outdated
| height: fontSize * text.length | ||
| height: Math.max(...text.map(t => { | ||
| const textMeasurement = g_fontSizeContext.measureText("" + t); | ||
| return textMeasurement.fontBoundingBoxDescent + textMeasurement.fontBoundingBoxAscent; |
There was a problem hiding this comment.
Based upon these docs https://developer.mozilla.org/en-US/docs/Web/API/TextMetrics#examples
There was a problem hiding this comment.
- The result still needs to be multiplied by
text.length - (optional) The calculation for width and height could be moved into a single
text.reducefunction.
There was a problem hiding this comment.
I couldn't think of a way to make text.reduce work, because the type of the accumulator must that of the individual items in the array, rather than whatever you want, eg an object containing the dimensions.
GordonSmith
requested changes
Nov 6, 2023
packages/common/src/Utility.ts
Outdated
| height: fontSize * text.length | ||
| height: Math.max(...text.map(t => { | ||
| const textMeasurement = g_fontSizeContext.measureText("" + t); | ||
| return textMeasurement.fontBoundingBoxDescent + textMeasurement.fontBoundingBoxAscent; |
There was a problem hiding this comment.
- The result still needs to be multiplied by
text.length - (optional) The calculation for width and height could be moved into a single
text.reducefunction.
jeclrsg
force-pushed
the
BreakdownTable-tooltip-height
branch
2 times, most recently
from
6c79ae6 to
8ddf098
Compare
GordonSmith
requested changes
Nov 7, 2023
packages/common/src/Utility.ts
Outdated
| @@ -736,11 +736,17 @@ export function textSize(_text: string | string[], fontName: string = "Verdana", | |||
| const hash = `${bold}::${fontSize}::${fontName}::${text.join("::")}`; | |||
| let retVal = g_fontSizeContextCache[hash]; | |||
| if (!retVal) { | |||
| let dimensions: TextSize = { width: 0, height: 0 }; | |||
There was a problem hiding this comment.
Change to retVal = { width: 0, height: 0 };
And then remove dimension below...
Signed-off-by: Jeremy Clements <[email protected]>
jeclrsg
force-pushed
the
BreakdownTable-tooltip-height
branch
from
8ddf098 to
5c77723
Compare
Merged
39 tasks
GordonSmith
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: