fix(comms): extend FileSpray.DFUWUFile to change reponse type to text #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be JSON consistent with WsWorkunits.WUFile Signed-off-by: Jeremy Clements <[email protected]>
39 tasks
GordonSmith
requested changes
Oct 24, 2023
| @@ -13,6 +13,10 @@ export interface UpdateDFUWorkunitEx extends UpdateDFUWorkunitMinusWU { | |||
|
|
|||
| export class FileSprayService extends FileSprayServiceBase { | |||
|
|
|||
| DFUWUFileEx(request: FileSpray.DFUWUFileRequest): Promise<string> { | |||
There was a problem hiding this comment.
Should keep the DFUWUFile name (especially since the generated version is invalid).
There was a problem hiding this comment.
I haven't been able to find a solution to this that doesn't seem like working around the rules. I did come across this answer on SO, which seemed like a good breakdown https://stackoverflow.com/a/62515586. Specifically, the third part where they suggested making the extended type be generic with a default of the preferred type. I thought that might be a good enhancement to the wsdl generator?
GordonSmith
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consistent with WsWorkunits.WUFile
Checklist:
Testing: