Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yadhap/jobmonitoring UI plus apis #683

Merged
merged 10 commits into from
Feb 5, 2024
Merged

Conversation

ydahal1
Copy link
Collaborator

@ydahal1 ydahal1 commented Jan 18, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Vulnerability fix (package bumps or CodeQL adjustments to ensure code security)
  • This change requires a documentation update

Developer Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved any conflicts with the branch I am attempting to merge to.
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have ensured that my code does not unecessarily duplicate existing cod
  • I have ensured that all security checks have been passed
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state

Reviewer Checklist

  • I have pulled the branch into my local environemtn and started the project succesfully
  • I have reviewed the code for proper comments and mispellings
  • All input boxes have sensible character limits applied
  • Refreshing related pages puts page in a workable and sensible state
  • Submitting any relevant Forms relays proper messaging to user
  • I have checked that all security checks have been passed
  • I have checked that all backend routes have proper validation

@ydahal1
Copy link
Collaborator Author

ydahal1 commented Jan 19, 2024

To test this PR , Delete and re-run the migration that creates job monitoring table

npx sequelize db:migrate:undo --name 20230228142810-create-jobMonitoring-table.js && npx sequelize db:migrate

@ydahal1 ydahal1 marked this pull request as ready for review February 2, 2024 18:42
@ydahal1 ydahal1 requested a review from fanchermatt February 2, 2024 18:45
@FancMa01 FancMa01 merged commit 7c81da8 into dev Feb 5, 2024
2 checks passed
@ydahal1 ydahal1 deleted the yadhap/jobmonitoring-ui-plus-apis branch February 28, 2024 21:33
@ydahal1 ydahal1 restored the yadhap/jobmonitoring-ui-plus-apis branch February 28, 2024 21:33
@ydahal1 ydahal1 deleted the yadhap/jobmonitoring-ui-plus-apis branch April 30, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants