Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Docker image for test such as Build Verification Test (BVT) #19395

Open
wants to merge 1 commit into
base: candidate-9.8.x
Choose a base branch
from

Conversation

xwang2713
Copy link
Member

The purpose to create a Docker image is to make a consistent environment for BVT and some other HPCC test which can target various HPCC Cloud environments as well as bare-metal deployments.

This will based on platform-core and include: 1) all required software 2) HPCC-Platform source 3) Test scripts for BVT and result handling 4) Some other basic tests

Build example:
docker build . -t hpccsystems/platform-test:9.8.44 --build-arg DOCKER_REPO=hpccsystems --build-arg BUILD_LABEL=9.8.44 --build-arg BRANCH=community_9.8.44-1 --build-arg GITHUB_TOKEN=

Signed off my [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Build with Docker Desktop (DD). Test the image and AKS through github action

@xwang2713
Copy link
Member Author

The instruction how to use this Docker image to test HPCC Deployment through EclWatch: https://github.com/hpcc-systems/cloud-testing/blob/main/BVT/README.md

# Others may not be wanted at all in container mode - scikit example??

ARG BUILD_LABEL
ARG DOCKER_REPO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these Args should have sane defaults. We can override DOCKER_REPO but it likely will be hpccsystems in most cases.

RUN echo "git checkout ${GIT_BRANCH}"
RUN cd /home/hpcc/HPCC-Platform && git checkout ${GIT_BRANCH}

RUN cd /home/hpcc && git clone https://oauth2:${GITHUB_TOKEN}@github.com/hpcc-systems/cloud-testing.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add an arg for the repo here so we can use this script to test changes in your repository before we push them up to hpcc-systems/cloud-testing. Although I'd keep the default for the arg as hpcc-systems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the change. Also I forgot to add code in github action to build it. Attila also updated the regress Quick Test code so I need make some changes in bvt.sh script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants