Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-33063 Fix Chrome and ChromeDriver version mismatch of ECL Watch UI test GH Action #19330

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

AttilaVamos
Copy link
Contributor

@AttilaVamos AttilaVamos commented Dec 3, 2024

test-ui-gh_runner.yml:
- Change Chrome Driver to version 128
- Change 'Download Support Files' actions/download-artifact@v3 to v4

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

github-actions bot commented Dec 3, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33063

Jirabot Action Result:
Workflow Transition To: Merge Pending
Additional PR: #19330

@AttilaVamos
Copy link
Contributor Author

@ghalliday This PR fixes the Chrome and Chromedriver version mismatch only, so the ECL Watch UI test is running.
However, it is still report an error related to the change in ECL-Watch from 9.6.x to 9.8.x (see: HPCC-33041).

Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. It seems to contain an extra commit though.

@ghalliday
Copy link
Member

@AttilaVamos please complete the checkboxes and rebase to avoid the extra commit.

@AttilaVamos AttilaVamos force-pushed the HPCC-33063-fix-master branch from 954a202 to 3e9e04e Compare December 9, 2024 11:31
@AttilaVamos
Copy link
Contributor Author

@ghalliday re based and check boxes are set.

…UI test GH Action

test-ui-gh_runner.yml:
- Change Chrome Driver to version 131
- Fix result artifact name problem

Signed-off-by: Attila Vamos <[email protected]>
@AttilaVamos AttilaVamos force-pushed the HPCC-33063-fix-master branch from 3e9e04e to 2ffcb87 Compare December 9, 2024 13:22
@ghalliday ghalliday merged commit dc7112c into hpcc-systems:master Dec 9, 2024
50 of 52 checks passed
Copy link

github-actions bot commented Dec 9, 2024

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants