Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32780 Extend STD.System.Workunit.WorkunitMessages to return priority and cost #19311

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Nov 22, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@shamser shamser requested a review from jakesmith November 22, 2024 16:18
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32780

Jirabot Action Result:
Workflow Transition To: Merge Pending

@shamser shamser requested review from ghalliday and removed request for jakesmith November 26, 2024 09:38
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser this is not backward compatible (if a previously compiled workunit is rerun on a new system without recompiling).

I think you need to

  • define a new implementation function.
  • pass a boolean into a shared implementation function to indicate whether the new fields should be added.
    See similar changes in fileservices.cpp plugin.

@shamser shamser requested a review from ghalliday December 6, 2024 09:25
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. It could do with a regression test though - please add one in a separate jira (to avoid this pr being delayed) - so that we can check that the code compiles and runs...
Please squash.

@shamser
Copy link
Contributor Author

shamser commented Dec 9, 2024

Change looks good. It could do with a regression test though - please add one in a separate jira (to avoid this pr being delayed) - so that we can check that the code compiles and runs... Please squash.

Jira for regression test: https://hpccsystems.atlassian.net/browse/HPCC-33095

@shamser shamser requested a review from ghalliday December 9, 2024 14:29
@ghalliday ghalliday merged commit ee9e2ff into hpcc-systems:master Dec 9, 2024
48 of 50 checks passed
Copy link

github-actions bot commented Dec 9, 2024

Jirabot Action Result:
Added fix version: 9.10.0
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants