HPCC-32957 ECL Watch ZAP dialog invalid date formats #19278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32957 Jirabot Action Result: |
GordonSmith
requested changes
Nov 7, 2024
| @@ -205,7 +205,7 @@ <h2> | |||
| <input id="${id}EndDateTime" name="LogFilter_AbsoluteTimeRange_EndDate" type="hidden" /> | |||
| <input id="${id}EndDate" title="${i18n.ToDate}:" name="EndDate" data-dojo-props="trim: true" required="required" data-dojo-type="dijit.form.DateTextBox" /> | |||
| <input id="${id}EndTime" title="" name="EndTime" data-dojo-props="trim: true" value="T19:30:00" data-dojo-type="dijit.form.TimeTextBox" /> | |||
| <input id="${id}RelativeTimeRangeBuffer" title="${i18n.RelativeTimeRange}" name="LogFilter_RelativeTimeRangeBuffer" colspan="2" data-dojo-type="dijit.form.TextBox" /> | |||
| <input id="${id}RelativeTimeRangeBuffer" title="${i18n.RelativeTimeRange}" name="LogFilter_RelativeTimeRangeBuffer" value="43200" colspan="2" data-dojo-type="dijit.form.TextBox" /> | |||
There was a problem hiding this comment.
What is 43200 representing here?
There was a problem hiding this comment.
That's the default that ESP sets, got added to the v9 UI a couple weeks ago, but not to the v5 version (added a comment on that PR, https://github.com/hpcc-systems/HPCC-Platform/pull/19216/files)
fixes an issue in both the v5 and v9 ECL Watch UIs, where in attemping to download a ZAP report the formatting of the date fields could be incorrect Signed-off-by: Jeremy Clements <[email protected]>
jeclrsg
force-pushed
the
hpcc-32957-zap-report-invalid-date-formats
branch
from
c379735 to
35517aa
Compare
GordonSmith
approved these changes
Nov 8, 2024
GordonSmith
merged commit 2d18715
into
hpcc-systems:candidate-9.2.x
50 of 51 checks passed
|
Jirabot Action Result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an issue in both the v5 and v9 ECL Watch UIs, where in attemping to download a ZAP report the formatting of the date fields could be incorrect
Type of change:
Checklist:
Smoketest:
Testing: