Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32824 ECL Watch v9 show Open Telemetry ids on WU details #19241

Merged
merged 1 commit into from
Nov 7, 2024
Merged

HPCC-32824 ECL Watch v9 show Open Telemetry ids on WU details #19241

merged 1 commit into from
Nov 7, 2024

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Oct 25, 2024

adds the Open Telemetry trace and span ids to the WU details page, as well as a button to easily copy these values out of the UI

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg
HPCC-32824 ECL Watch v9 show Open Telemetry ids on WU details
a610226 
adds the Open Telemetry trace and span ids to the WU details page, as
well as a button to easily copy these values out of the UI

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg requested a review from GordonSmith October 25, 2024 16:39
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32824

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

jeclrsg
jeclrsg commented Oct 25, 2024
View reviewed changes
esp/src/src-react/components/WorkunitSummary.tsx
icons: {
"open-telemetry": (
// .../eclwatch/img/opentelemetry-icon-color.svg
<svg xmlns="http://www.w3.org/2000/svg" role="img" viewBox="-12.70 -12.70 1024.40 1024.40"><path fill="#f5a800" d="M528.7 545.9c-42 42-42 110.1 0 152.1s110.1 42 152.1 0 42-110.1 0-152.1-110.1-42-152.1 0zm113.7 113.8c-20.8 20.8-54.5 20.8-75.3 0-20.8-20.8-20.8-54.5 0-75.3 20.8-20.8 54.5-20.8 75.3 0 20.8 20.7 20.8 54.5 0 75.3zm36.6-643l-65.9 65.9c-12.9 12.9-12.9 34.1 0 47l257.3 257.3c12.9 12.9 34.1 12.9 47 0l65.9-65.9c12.9-12.9 12.9-34.1 0-47L725.9 16.7c-12.9-12.9-34-12.9-46.9 0zM217.3 858.8c11.7-11.7 11.7-30.8 0-42.5l-33.5-33.5c-11.7-11.7-30.8-11.7-42.5 0L72.1 852l-.1.1-19-19c-10.5-10.5-27.6-10.5-38 0-10.5 10.5-10.5 27.6 0 38l114 114c10.5 10.5 27.6 10.5 38 0s10.5-27.6 0-38l-19-19 .1-.1 69.2-69.2z" /><path fill="#425cc7" d="M565.9 205.9L419.5 352.3c-13 13-13 34.4 0 47.4l90.4 90.4c63.9-46 153.5-40.3 211 17.2l73.2-73.2c13-13 13-34.4 0-47.4L613.3 205.9c-13-13.1-34.4-13.1-47.4 0zm-94 322.3l-53.4-53.4c-12.5-12.5-33-12.5-45.5 0L184.7 663.2c-12.5 12.5-12.5 33 0 45.5l106.7 106.7c12.5 12.5 33 12.5 45.5 0L458 694.1c-25.6-52.9-21-116.8 13.9-165.9z" /></svg>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be imported from an .svg file rather than inlined. Something like import { OpenTelemetryIcon } from "eclwatch/img/opentelemetry-icon-color.svg"; and then ..."open-telemetry": (<OpenTelemetryIcon />)... probably? But I wasn't able to figure out how to change the webpack config to enable that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inlined is fine - helps if you turn off word wrap I suspect!

@GordonSmith
Copy link
Member

@jeclrsg is this delibertly targetting 9.4.x instead of 9.2.x?

@jeclrsg
Copy link
Contributor Author

jeclrsg commented Nov 4, 2024

@jeclrsg is this delibertly targetting 9.4.x instead of 9.2.x?

It is. The open telemetry info doesn't seem to be available in any 9.2.x.

@GordonSmith GordonSmith merged commit 0dc7a08 into hpcc-systems:candidate-9.4.x Nov 7, 2024
51 of 52 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Jirabot Action Result:
Added fix version: 9.4.112
Added fix version: 9.6.64
Added fix version: 9.8.38
Workflow Transition: 'Resolve issue'

@jeclrsg jeclrsg deleted the hpcc-32824-wu-details-otel-info branch December 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeclrsg @GordonSmith