-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32111 Use compression in global merge activity #19238
HPCC-32111 Use compression in global merge activity #19238
Conversation
@ghalliday - please review. Questionable whether should be 9.8 vs master. |
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32111 Jirabot Action Result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakesmith 1 minor question.
unsigned spillCompInfo; | ||
setCompFlag(compType, spillCompInfo); | ||
if (spillCompInfo) | ||
rwFlags |= rw_compress; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rwFlags |= spillCompInfo;
for consistency with elsewhere? Really this should be a single piece of common code.... but that can be a separate refactoring. The same logic seems to be done two different ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I meant to have it like that, now fixed.
Have opened separate JIRA to common code like this: https://hpccsystems.atlassian.net/browse/HPCC-32881
bc1ad0f
to
dac0255
Compare
dac0255
to
f896d5e
Compare
Signed-off-by: Jake Smith <[email protected]>
f896d5e
to
a84be5f
Compare
@ghalliday - uninitialized issue fixed/squashed in. |
Jirabot Action Result: |
Type of change:
Checklist:
Smoketest:
Testing: