Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32111 Use compression in global merge activity #19238

Merged

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Oct 25, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith jakesmith requested a review from ghalliday October 25, 2024 11:47
@jakesmith
Copy link
Member Author

@ghalliday - please review. Questionable whether should be 9.8 vs master.

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32111

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith 1 minor question.

unsigned spillCompInfo;
setCompFlag(compType, spillCompInfo);
if (spillCompInfo)
rwFlags |= rw_compress;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rwFlags |= spillCompInfo;

for consistency with elsewhere? Really this should be a single piece of common code.... but that can be a separate refactoring. The same logic seems to be done two different ways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant to have it like that, now fixed.
Have opened separate JIRA to common code like this: https://hpccsystems.atlassian.net/browse/HPCC-32881

@jakesmith jakesmith force-pushed the HPCC-32111-merge-compress branch from bc1ad0f to dac0255 Compare October 25, 2024 12:31
@jakesmith jakesmith requested a review from ghalliday October 25, 2024 12:32
@jakesmith jakesmith force-pushed the HPCC-32111-merge-compress branch from dac0255 to f896d5e Compare October 25, 2024 14:37
@jakesmith jakesmith force-pushed the HPCC-32111-merge-compress branch from f896d5e to a84be5f Compare October 31, 2024 16:42
@jakesmith jakesmith requested a review from ghalliday October 31, 2024 16:42
@jakesmith
Copy link
Member Author

@ghalliday - uninitialized issue fixed/squashed in.

@ghalliday ghalliday merged commit bf157ea into hpcc-systems:candidate-9.8.x Nov 1, 2024
51 checks passed
Copy link

github-actions bot commented Nov 1, 2024

Jirabot Action Result:
Added fix version: 9.8.36
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants