Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32770 Soapcall stats for DNS, connect, num failures #19183

Merged
merged 1 commit into from
Oct 9, 2024
Merged

HPCC-32770 Soapcall stats for DNS, connect, num failures #19183

merged 1 commit into from
Oct 9, 2024

Conversation

mckellyln
Copy link
Contributor

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32770

Jirabot Action Result:
Assigning user: [email protected]
Workflow Transition To: Merge Pending
Updated PR

@mckellyln mckellyln requested a review from ghalliday October 3, 2024 20:15
ghalliday
ghalliday reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mckellyln looks good, a couple of minor comments.

common/thorhelper/thorsoapcall.cpp Outdated
// TODO: for DNS, do we use timeoutMS or remainingMS or remainingMS / maxRetries+1 or ?
ep.set(connUrl.host.get(), connUrl.port, master->timeoutMS);

master->logctx.noteStatistic(StTimeSoapcallDNS, dnsTimer.elapsedNs());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth assigning elapsedNs to a temporary and then dividing for the next one to avoid an extra call to get_cycles_now?
Actually, probably better to record Ns in the span - that is what the general stat processing does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that so just one call. I can do that.
But for the Span - its just an attribute so I didn't think any processing was done on it ?
Do you mean use "Ns" label in the Span attribute as well and then use the same value as the stat ?

system/jlib/jstatcodes.h Outdated
@@ -311,6 +311,11 @@ enum StatisticKind
StNumMatchRightRowsMax,
StNumMatchCandidates,
StNumMatchCandidatesMax,
StTimeSoapcallDNS, // Time spent in DNS lookups for soapcalls
StTimeSoapcallConn, // Time spent in connect[+SSL_connect] for soapcalls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect would be better than Conn (since this is seen by the user)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I was just trying to save some chars.

@mckellyln mckellyln requested a review from ghalliday October 4, 2024 11:46
@mckellyln
Copy link
Contributor Author

@ghalliday thx, updated for re-review.

@mckellyln mckellyln force-pushed the hpcc-32770 branch 2 times, most recently from 3c7b6a2 to db33ba1 Compare October 6, 2024 23:13
ghalliday
ghalliday approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mckellyln please squash. Merging it may be slightly tricky because of a potential clash with changes in other PRs. How important is it that this goes in 9.6.x? I know it could be very valuable.

@mckellyln
Copy link
Contributor Author

Squashed.
Yes do want this into 9.6 if possible only because of the long lead time for next upgrade to 9.8

@ghalliday
Copy link
Member

I will merge once #19190 is merged and this is rebased on top of that.

@ghalliday ghalliday merged commit d9787ff into hpcc-systems:candidate-9.6.x Oct 9, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mckellyln @ghalliday