Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32766 Decompress partition points to roxiemem in global sort #19178

Merged
merged 1 commit into from
Oct 3, 2024
Merged

HPCC-32766 Decompress partition points to roxiemem in global sort #19178

merged 1 commit into from
Oct 3, 2024

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Oct 3, 2024 •
edited
Loading

Configurable for now, default on.
Use Roxiemem to decompress received partition points from workers, to reduce heap usage (which can lead to OOM death).

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith
HPCC-32766 Decompress partition points to roxiemem in global sort
1d6ea22 
Configurable for now, default on.
Use Roxiemem to decompress received partition points from workers,
to reduce heap usage (which can lead to OOM death).

Signed-off-by: Jake Smith <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32766

Jirabot Action Result:
Assigning user: [email protected]
Workflow Transition To: Merge Pending
Updated PR

@jakesmith jakesmith requested a review from ghalliday October 3, 2024 10:58
@jakesmith
Copy link
Member Author

@ghalliday - please review. I think master is the right target, but it's one of those cases where I don't think changes like this should go in point builds, but minor builds are too infrequent IMO.

ghalliday
ghalliday approved these changes Oct 3, 2024
View reviewed changes
thorlcr/thorutil/thmem.cpp
{
size32_t written = fastlz_decompress(sz,cmpsz,o,expsz);
if (written!=expsz)
throw MakeStringException(0, "fastLZDecompressToBuffer - corrupt data(1) %d %d",written,expsz);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picky: Should really be %u for unsigned values.

thorlcr/msort/tsortm.cpp
void *p;
slave.GetMultiNthRow(slavesamples, samplebufsize, p);
samplebuf.setown(p);
size32_t expandedSz;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a similar pattern appears anywhere else, then this code could be extracted into a class, and commoned up with the code below. Not worth it otherwise.

@ghalliday ghalliday merged commit a6cacdc into hpcc-systems:master Oct 3, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakesmith @ghalliday