Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32532 ECL Watch v9 support for Grafana/Loki logging #19169

Merged

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Oct 1, 2024

adds support to ECL Watch v9 for displaying logs from Grafana/Loki

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith October 1, 2024 17:28
Copy link

github-actions bot commented Oct 1, 2024

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32532

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@jeclrsg jeclrsg marked this pull request as draft October 2, 2024 15:18
@jeclrsg
Copy link
Contributor Author

jeclrsg commented Oct 2, 2024

Converted this to a draft because it will have conflicts with #19173 and so should be rebased after that is merged.

adds support to ECL Watch v9 for displaying logs from Grafana/Loki

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg force-pushed the hpcc-32532-loki-logging branch from 922ecb6 to f8e933a Compare October 8, 2024 20:21
@jeclrsg jeclrsg marked this pull request as ready for review October 8, 2024 21:01
@GordonSmith GordonSmith merged commit 767a7b0 into hpcc-systems:candidate-9.6.x Oct 14, 2024
54 checks passed
@jeclrsg jeclrsg deleted the hpcc-32532-loki-logging branch December 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants