Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32720 Fix multiJobLinger=false configurations #19149

Merged
merged 1 commit into from
Oct 3, 2024
Merged

HPCC-32720 Fix multiJobLinger=false configurations #19149

merged 1 commit into from
Oct 3, 2024

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Sep 25, 2024 •
edited
Loading

Revert to using IP (not hostname) for inter pod communication for communicating subsequent job graphs.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jakesmith jakesmith requested a review from ghalliday September 25, 2024 13:46
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32720

Jirabot Action Result:
Assigning user: [email protected]
Workflow Transition To: Merge Pending
Updated PR

ghalliday
ghalliday reviewed Sep 25, 2024
View reviewed changes
thorlcr/master/thgraphmanager.cpp Outdated
@@ -1457,7 +1457,8 @@ void thorMain(ILogMsgHandler *logHandler, const char *wuid, const char *graphNam
thorQueue->connect(false);
}

queryMyNode()->endpoint().getEndpointHostText(instance);
queryMyNode()->endpoint().getEndpointIpText(instance);
StringBuffer currentWfId; // not filled/not used until recvNextGraph() is called.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this included by mistake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think must have been when I rebased on to 9.6 (it is introduced later)

ghalliday
ghalliday reviewed Sep 25, 2024
View reviewed changes
thorlcr/master/thgraphmanager.cpp Outdated
@@ -1457,7 +1457,8 @@ void thorMain(ILogMsgHandler *logHandler, const char *wuid, const char *graphNam
thorQueue->connect(false);
}

queryMyNode()->endpoint().getEndpointHostText(instance);
queryMyNode()->endpoint().getEndpointIpText(instance);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a comment to explain why Ip is extracted rather than host name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have added comments.

@jakesmith jakesmith requested a review from ghalliday September 30, 2024 10:39
@jakesmith jakesmith force-pushed the HPCC-32720-fix-multiJobLinger-false branch from 3588de9 to c83e383 Compare September 30, 2024 10:41
@jakesmith
Copy link
Member Author

@ghalliday - please see comments in new commit

ghalliday
ghalliday approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakesmith looks good - please squash.

@jakesmith
HPCC-32720 Fix multiJobLinger=false configurations
feb6a2d 
Revert to using IP (not hostname) for inter pod communication for
communicating subsequent job graphs.
@jakesmith jakesmith force-pushed the HPCC-32720-fix-multiJobLinger-false branch from c83e383 to feb6a2d Compare October 3, 2024 13:16
@jakesmith
Copy link
Member Author

@jakesmith looks good - please squash.

@ghalliday - squashed.

@ghalliday ghalliday merged commit 9a27571 into hpcc-systems:candidate-9.6.x Oct 3, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakesmith @ghalliday