Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32713 ECL Watch v9 fix WU list not sorting #19146

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Sep 24, 2024

fix an issue with the Grid's use of request abort signals

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

fix an issue with the Grid's use of request abort signals

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg requested a review from GordonSmith September 24, 2024 16:15
@@ -260,7 +260,7 @@ const FluentStoreGrid: React.FunctionComponent<FluentStoreGridProps> = ({
setItems(items);
selectedIndices.forEach(index => selectionHandler.setIndexSelected(index, true, false));
});
}, [count, selectionHandler, start, store], [query, sorted]);
}, [abortController?.current?.signal, count, selectionHandler, start, store], [query, sorted]);
Copy link
Member

@GordonSmith GordonSmith Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be an anti-pattern (having a Ref trigger an effect)?

Also I wonder if we could convert this to a regular React.useCallback?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an effect involved? Looking at useDeepCallback, it's a useCallback that has a useDeepCompareMemoize for the second array of dependencies. But I didn't see a useEffect anywhere in there.

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32713

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@GordonSmith GordonSmith self-requested a review September 27, 2024 09:40
@GordonSmith GordonSmith merged commit 5c4da75 into candidate-9.2.x Sep 27, 2024
51 of 52 checks passed
@jeclrsg jeclrsg deleted the hpcc-32713-wu-list-not-sorting branch September 30, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants