Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32121 Fix configvalues file in the PT_BR container doc #18953

Conversation

vfumene
Copy link
Contributor

@vfumene vfumene commented Aug 2, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Signed-off-by: Valdir Fumene Junior <[email protected]>
@g-pan g-pan self-requested a review August 2, 2024 18:43
@g-pan g-pan changed the title Fixing the configvalues file HPCC-32121 Fixing the configvalues file Aug 2, 2024
Copy link
Member

@g-pan g-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All tests passed. Not showing conflicts. Approved.

@g-pan
Copy link
Member

g-pan commented Aug 8, 2024

@ghalliday should be good to merge.

@ghalliday
Copy link
Member

@vfumene please can you update the commit message so that it will make sense on its own in a change log. (This does not indicate it is updating the Portuguese documentation)

@vfumene vfumene changed the title HPCC-32121 Fixing the configvalues file HPCC-32121 Fix configvalues file in the PT_BR container doc Aug 9, 2024
@g-pan
Copy link
Member

g-pan commented Aug 13, 2024

@ghalliday should be ready to merge

@ghalliday
Copy link
Member

@vfumene you have changed the title of the PR, but not the title of the commit message. (try git commit --amend)

@ghalliday
Copy link
Member

@vfumene Please see note above about changing the commit message.

@ghalliday ghalliday merged commit ff40b3c into hpcc-systems:candidate-9.6.x Oct 18, 2024
51 of 52 checks passed
Copy link

Jirabot Action Result:
Added fix version: 9.6.58
Added fix version: 9.8.32
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants