Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-32228 Add fixed_size_binary data type to Parquet Plugin #18888

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

ilhan2316
Copy link
Contributor

@ilhan2316 ilhan2316 commented Jul 17, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32228

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@jackdelv jackdelv self-requested a review July 17, 2024 14:40
Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilhan2316 I think it's close. There are just a few style issues that need to be fixed.

There were a few cases where extra lines were added and not needed. I commented those with Extra Line.

plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.hpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.hpp Show resolved Hide resolved
plugins/parquet/parquetembed.hpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilhan2316 It looks good. There are still a few places with trailing spaces or too few spaces. I have placed comments at those points.

I think that after these changes the documentation should be updated. Please create a JIRA for updating the Parquet documentation with this type and large_list.

plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
@ilhan2316 ilhan2316 requested a review from jackdelv July 19, 2024 14:55
Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilhan2316 It's close. I just have one question that may require a little investigation.

plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.hpp Outdated Show resolved Hide resolved
@ilhan2316 ilhan2316 requested a review from jackdelv July 23, 2024 16:38
Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very close. There are just a few style issues, but the changes look correct.

plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
@ilhan2316 ilhan2316 requested a review from jackdelv July 24, 2024 15:11
Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last style nitpick.

plugins/parquet/parquetembed.cpp Outdated Show resolved Hide resolved
@ilhan2316 ilhan2316 requested a review from jackdelv July 24, 2024 15:21
Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilhan2316 The changes look good.

@jackdelv jackdelv requested a review from dcamper July 24, 2024 15:58
Copy link
Contributor

@dcamper dcamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dcamper
Copy link
Contributor

dcamper commented Jul 24, 2024

Offline commented noted here for posterity and note-keeping: Investigation into using .emplace_back() instead of .push_back() may be a good idea.

@jackdelv
Copy link
Contributor

@ilhan2316 Please squash to a single commit.

@ilhan2316
Copy link
Contributor Author

@ghalliday This is ready to be merged. Please take a look.

@ilhan2316 ilhan2316 force-pushed the HPCC-32228 branch 3 times, most recently from be0072a to 71b623c Compare July 25, 2024 21:09
@ilhan2316 ilhan2316 requested a review from jackdelv July 25, 2024 21:11
@ghalliday
Copy link
Member

@ilhan2316 please can you squash the commits

@ilhan2316
Copy link
Contributor Author

@ghalliday I have squashed.

@ghalliday
Copy link
Member

@jackdelv please can you review/approve

Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday The changes are correct.

@ghalliday ghalliday merged commit 727c51a into hpcc-systems:candidate-9.6.x Aug 5, 2024
145 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants