Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-32218 Implement StNumParallelExecute stat for activities #18870

Merged
merged 1 commit into from
Jul 18, 2024
Merged

HPCC-32218 Implement StNumParallelExecute stat for activities #18870

merged 1 commit into from
Jul 18, 2024

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Jul 11, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32218

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

jakesmith
jakesmith reviewed Jul 11, 2024
View reviewed changes
system/jlib/jstats.cpp Outdated
@@ -983,6 +983,7 @@ static const constexpr StatisticMeta statsMetaData[StMax] = {
{ NUMSTAT(MatchRightRowsMax), "The largest number of right rows in a join group" },
{ NUMSTAT(MatchCandidates), "The number of candidate combinations of left and right rows forming join groups" },
{ NUMSTAT(MatchCandidatesMax), "The largest number of candidate combinations of left and right rows in a single group" },
{ NUMSTAT(Threads), "The number of threads (strands) used by activity" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily strands in other contexts, e.g. if we start reporting number of threads used by keyed join, hash distrib.. Probably best to just drop "(strands)" here.

jakesmith
jakesmith reviewed Jul 11, 2024
View reviewed changes
thorlcr/thorutil/thormisc.cpp Outdated
@@ -76,6 +76,7 @@ static Owned<IMPtagAllocator> ClusterMPAllocator;
const StatisticsMapping spillStatistics({StTimeSpillElapsed, StTimeSortElapsed, StNumSpills, StSizeSpillFile, StSizePeakTempDisk});
const StatisticsMapping soapcallStatistics({StTimeSoapcall});
const StatisticsMapping basicActivityStatistics({StTimeTotalExecute, StTimeLocalExecute, StTimeBlocked});
const StatisticsMapping strandedActivityStatistics({StNumThreads}, basicActivityStatistics);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add numThreads to basicActivityStatistics, as many activities use threads, even if project will be the only one for now, that will report it.

jakesmith
jakesmith reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - see minor comments, but looks like it will be a good change.

@shamser shamser requested a review from jakesmith July 11, 2024 11:30
jakesmith
jakesmith previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good please squash.

@jakesmith
Copy link
Member

@shamser - have pushed a comment to JIRA, can we rename this to “numParallelExecute” ?

@jakesmith jakesmith dismissed their stale review July 16, 2024 10:55

pending numParallelExecute rename

@shamser shamser changed the title HPCC-32218 StNumThreads for stranded activities HPCC-32218 Implement StNumParallelExecute stat for activities Jul 16, 2024
@shamser shamser requested a review from jakesmith July 16, 2024 11:17
jakesmith
jakesmith approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good, please squash

@shamser shamser requested a review from jakesmith July 17, 2024 10:53
jakesmith
jakesmith approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good.

ghalliday
ghalliday requested changes Jul 17, 2024
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser main change looks good. One comment about the description.

system/jlib/jstats.cpp Outdated
@@ -983,6 +983,7 @@ static const constexpr StatisticMeta statsMetaData[StMax] = {
{ NUMSTAT(MatchRightRowsMax), "The largest number of right rows in a join group" },
{ NUMSTAT(MatchCandidates), "The number of candidate combinations of left and right rows forming join groups" },
{ NUMSTAT(MatchCandidatesMax), "The largest number of candidate combinations of left and right rows in a single group" },
{ NUMSTAT(ParallelExecute), "The number of parallel execution of the activity" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: This description doesn't quite make sense. "...parallel execution paths/threads/workers for the...". Worth changing because this is a string presented to the user.

@shamser shamser requested a review from ghalliday July 17, 2024 15:54
@ghalliday ghalliday merged commit a398e73 into hpcc-systems:candidate-9.8.x Jul 18, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamser @jakesmith @ghalliday