Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31885 Only trace optimizations from eclcc if -ftraceOptimizations=1 #18832

Merged
merged 1 commit into from
Jul 24, 2024
Merged

HPCC-31885 Only trace optimizations from eclcc if -ftraceOptimizations=1 #18832

merged 1 commit into from
Jul 24, 2024

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Jun 28, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@ghalliday ghalliday requested a review from shamser June 28, 2024 15:24
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31885

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

shamser
shamser requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@shamser shamser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear how the current options.traceAll works with the new eclccTraceOptions. Does traceNone, traceStandard etc supersede the traceAll option?

ecl/hql/hqlfold.cpp
@@ -6540,7 +6552,10 @@ IHqlExpression * CExprFolderTransformer::createTransformed(IHqlExpression * expr

#ifdef LOG_ALL_FOLDING
if ((op != transformed->getOperator()) || (expr->numChildren() != transformed->numChildren()))
DBGLOG("Folding %s to %s", getOpString(updated->getOperator()), getOpString(transformed->getOperator()));
{
if (doTrace(traceOptimizations))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Can doTrace wrap the if block two lines above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, but it is inside a #ifdef that is not defined.

ecl/hqlcpp/hqlcpp.cpp
@@ -1946,6 +1946,8 @@ void HqlCppTranslator::cacheOptions()
}
}

updateTraceFlags(loadTraceFlags(wu(), eclccTraceOptions, queryTraceFlags()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a options.traceAll Debug option (line 1921 of this file). Should loadTraceFlags be making use of this options.traceAll?

@ghalliday ghalliday requested a review from shamser July 19, 2024 10:01
@ghalliday ghalliday merged commit 7644ea3 into hpcc-systems:candidate-9.6.x Jul 24, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamser shamser shamser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghalliday @shamser