Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31787 ECL Watch v9 LogViewer copy button formatting #18640

Merged
merged 1 commit into from
May 16, 2024
Merged

HPCC-31787 ECL Watch v9 LogViewer copy button formatting #18640

merged 1 commit into from
May 16, 2024

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented May 10, 2024

Add an optional csvFormatter function to grid columns that can return a text-formatted version of the value for the copy/download buttons. For example, on the LogViewer component, translate the Severity enums to strings, returning "info" or "warning" rather than 1 or 2.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith May 10, 2024 18:08
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31787

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

GordonSmith
GordonSmith requested changes May 13, 2024
View reviewed changes
esp/src/src-react/components/LogViewer.tsx Outdated
@@ -45,7 +45,8 @@ export const LogViewer: React.FunctionComponent<LogViewerProps> = ({
const colors = logColor(level);
const styles = { backgroundColor: colors.background, padding: "2px 6px", color: colors.foreground };
return <span style={styles}>{Level[level].toUpperCase()}</span>;
}
},
csvFormatter: level => Level[level]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add the "toUpperCase" as well?

esp/src/src/Utility.ts Show resolved Hide resolved
@jeclrsg
HPCC-31787 ECL Watch v9 LogViewer copy button formatting
9baab1f 
Add an optional csvFormatter function to grid columns that can return
a text-formatted version of the value for the copy/download buttons.
For example, on the LogViewer component, translate the Severity enums
to strings, returning "info" or "warning" rather than 1 or 2.

Signed-off-by: Jeremy Clements <[email protected]>
@jeclrsg jeclrsg force-pushed the hpcc-31787-copy-buttons-formatting branch from 1dafed0 to 9baab1f Compare May 15, 2024 16:06
@GordonSmith GordonSmith merged commit 1316385 into hpcc-systems:candidate-9.2.x May 16, 2024
51 checks passed
@jeclrsg jeclrsg deleted the hpcc-31787-copy-buttons-formatting branch July 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeclrsg @GordonSmith