Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31672 Update Std.DataPatterns.Profile to version 1.9.4 #18578

Conversation

dcamper
Copy link
Contributor

@dcamper dcamper commented Apr 23, 2024

Uses short form of Unicode property names for regex statements.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Manually tested with ICU-based regex for compatibility.

@dcamper dcamper requested a review from ghalliday April 23, 2024 18:45
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31672

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@ghalliday
Copy link
Member

Before I merge, should this target 9.6.x to help prepare for the unicode change?

Uses short form of Unicode property names for regex statements.
@dcamper dcamper force-pushed the hpcc-31672-datapatterns-profile-1.9.4 branch from d66dc8f to 1567d61 Compare April 26, 2024 11:58
@dcamper dcamper changed the base branch from master to candidate-9.6.x April 26, 2024 11:58
@dcamper
Copy link
Contributor Author

dcamper commented Apr 26, 2024

@ghalliday: Rebased to 9.6.x.

At first, I didn't think it mattered. But then I thought that perhaps the longer runway for someone to update their client tools would be beneficial, for those who run DataPatterns.Profile() in their own code.

Thanks!

@ghalliday ghalliday merged commit ce59642 into hpcc-systems:candidate-9.6.x Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants