Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31671 Add resolved "CommandMessage" field to GetDFUWorkunits result. #18576

Merged

Conversation

AttilaVamos
Copy link
Contributor

@AttilaVamos AttilaVamos commented Apr 23, 2024

Tested locally

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@AttilaVamos AttilaVamos requested a review from jakesmith April 23, 2024 14:52
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31671

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@AttilaVamos AttilaVamos changed the title HPCC-31671 Add resolved "CommandMessage" field to GetDFUWorkunits resslt. HPCC-31671 Add resolved "CommandMessage" field to GetDFUWorkunits result. Apr 24, 2024
DFUcmd command = wu->getCommand();
resultWU->setCommand(command);
encodeDFUcommand(command, cmdStr);
resultWU->setCommandMessage(cmdStr.str());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[min_ver("1.03")] string CommandMessage;

This code should be wrapped in a version check (>= 1.03):

            if (version >= 1.03)
            {
                encodeDFUcommand(command, cmdStr);
                resultWU->setCommandMessage(cmdStr.str());
            }

Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AttilaVamos - one minor issue

@AttilaVamos AttilaVamos requested a review from jakesmith April 26, 2024 14:32
resultWU->setJobName(wu->getJobName(jobname).str());
DFUcmd command = wu->getCommand();
resultWU->setCommand(command);
encodeDFUcommand(command, cmdStr);
resultWU->setCommandMessage(cmdStr.str());
if ( version >=1.03 )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial/style: non-standard spacing.

Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AttilaVamos - it's fine, but see comment re. unusual spacing

@AttilaVamos AttilaVamos requested a review from jakesmith April 26, 2024 16:47
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AttilaVamos - looks good.

@jakesmith
Copy link
Member

@AttilaVamos - please squash

@AttilaVamos AttilaVamos force-pushed the HPCC-31671-9.6.x-impr branch from 184c39e to feb94f9 Compare April 26, 2024 18:20
@AttilaVamos
Copy link
Contributor Author

@jakesmith squashed.
@ghalliday please merge.

@ghalliday ghalliday merged commit d5a8ba7 into hpcc-systems:candidate-9.6.x Apr 29, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants