-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-31671 Add resolved "CommandMessage" field to GetDFUWorkunits result. #18576
HPCC-31671 Add resolved "CommandMessage" field to GetDFUWorkunits result. #18576
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31671 Jirabot Action Result: |
esp/services/ws_fs/ws_fsService.cpp
Outdated
DFUcmd command = wu->getCommand(); | ||
resultWU->setCommand(command); | ||
encodeDFUcommand(command, cmdStr); | ||
resultWU->setCommandMessage(cmdStr.str()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[min_ver("1.03")] string CommandMessage;
This code should be wrapped in a version check (>= 1.03):
if (version >= 1.03)
{
encodeDFUcommand(command, cmdStr);
resultWU->setCommandMessage(cmdStr.str());
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AttilaVamos - one minor issue
esp/services/ws_fs/ws_fsService.cpp
Outdated
resultWU->setJobName(wu->getJobName(jobname).str()); | ||
DFUcmd command = wu->getCommand(); | ||
resultWU->setCommand(command); | ||
encodeDFUcommand(command, cmdStr); | ||
resultWU->setCommandMessage(cmdStr.str()); | ||
if ( version >=1.03 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trivial/style: non-standard spacing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AttilaVamos - it's fine, but see comment re. unusual spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AttilaVamos - looks good.
@AttilaVamos - please squash |
…ult. Tested locally Signed-off-by: Attila Vamos <[email protected]>
184c39e
to
feb94f9
Compare
@jakesmith squashed. |
Tested locally
Type of change:
Checklist:
Smoketest:
Testing: