Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31454 Enable Parquet interface in client tools #18562

Merged

Conversation

dcamper
Copy link
Contributor

@dcamper dcamper commented Apr 19, 2024

The Parquet shared library is not available in client tools, but parquet (the file type) can at least be referenced in ECL code when using the new generic disk reader code.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@dcamper dcamper requested review from GordonSmith and jackdelv April 19, 2024 15:21
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31454

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have one question.

@@ -1,6 +1,6 @@
##############################################################################

# HPCC SYSTEMS software Copyright (C) 2022 HPCC Systems®.
# HPCC SYSTEMS software Copyright (C) 2022 HPCC Systems.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't make that change myself, and I assumed that some editor was fixing it. On my system, it now looks like:

HPCC SYSTEMS software Copyright (C) 2022 HPCC Systems®.

That is Unicode character 00AE.

I just compared it with the same character in plugins/kafka/CMakeLists.txt and it is the same (00AE).

I think it's correct, just not rendered correctly here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that, in my previous comment, I was comparing characters in a difference git branch. After switching to the right branch I see that this character is wrong.

I will revert this change in this file.

Shared library is not available in client tools, but it can at least be referenced in ECL code.
@dcamper dcamper force-pushed the hpcc-31454-parquet-clienttools branch from dc3bba5 to 97b0560 Compare April 19, 2024 16:08
@dcamper dcamper requested a review from jackdelv April 19, 2024 16:08
Copy link
Contributor

@jackdelv jackdelv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok - does this mean that parquet will be recognised in the clienttools, while not being included?

@dcamper
Copy link
Contributor Author

dcamper commented Apr 22, 2024

Exactly. It only affects generic disk read code, and specifically whether a file type of 'parquet' is recognized. With this PR, that will happen even though the Parquet shared libraries are not linked.

@dcamper
Copy link
Contributor Author

dcamper commented Apr 22, 2024

@ghalliday Please merge.

@ghalliday ghalliday merged commit 442adb4 into hpcc-systems:candidate-9.6.x Apr 23, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants