Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31567 Add Next + Prev buttons to WU Details Page #18561

Merged
merged 1 commit into from
Apr 25, 2024
Merged

HPCC-31567 Add Next + Prev buttons to WU Details Page #18561

merged 1 commit into from
Apr 25, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Apr 19, 2024 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg April 19, 2024 15:18
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31567

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

jeclrsg
jeclrsg approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith I kind of wish there was some kind of feedback if there isn't a next or previous, but 99% of the time there will be, I'd expect.

jeclrsg
jeclrsg reviewed Apr 19, 2024
View reviewed changes
esp/src/src-react/components/WorkunitSummary.tsx Outdated
const buttons = React.useMemo((): ICommandBarItemProps[] => [
{
key: "previous", iconOnly: true, tooltipHostProps: { content: nlsHPCC.previousWorkunit }, iconProps: { iconName: "Previous" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed it when I was looking earlier, but lint was complaining about the casing of nlsHPCC.previousWorkunit & nextWorkunit

@GordonSmith GordonSmith marked this pull request as draft April 22, 2024 16:37
@GordonSmith GordonSmith force-pushed the HPCC-31567-WUDETAILS_NEXT_PREV branch from d0dcdc2 to 8fdb01d Compare April 25, 2024 07:09
@GordonSmith GordonSmith requested a review from jeclrsg April 25, 2024 07:39
@GordonSmith GordonSmith force-pushed the HPCC-31567-WUDETAILS_NEXT_PREV branch from 8fdb01d to 959dba8 Compare April 25, 2024 07:43
@GordonSmith GordonSmith marked this pull request as ready for review April 25, 2024 07:44
@GordonSmith
Copy link
Member Author

@jeclrsg fixed nlsHPCC, added a warning when next/prev fails and swapped next/previous actions.

@GordonSmith GordonSmith merged commit 529bb0f into hpcc-systems:candidate-9.2.x Apr 25, 2024
51 checks passed
@GordonSmith GordonSmith deleted the HPCC-31567-WUDETAILS_NEXT_PREV branch April 25, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg