-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-31588 JFrog deletion rules and cleanup workflow #18559
HPCC-31588 JFrog deletion rules and cleanup workflow #18559
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31588 Jirabot Action Result: |
0f24678
to
eb0afcf
Compare
@ghalliday If these rules look good for you, I'd like to manually run the workflow to do a final test (and the first major deletion) before we merge. Just to double check that deleting a lot of objects at once isn't going to cause an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - Some minor suggestions....
202c68a
to
2db18c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A couple of comments. I have also reached out to see what effect this will have on other teams, before merging and removing lots of old versions.
Signed-off-by: Michael Gardner <[email protected]>
2db18c6
to
d8f6c4f
Compare
@ghalliday Added the comments suggested. |
Type of change:
Checklist:
Smoketest:
Testing:
Here is an example of a dry run from my repository. https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/8744376977/job/23997086869