Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31588 JFrog deletion rules and cleanup workflow #18559

Merged

Conversation

Michael-Gardner
Copy link
Contributor

@Michael-Gardner Michael-Gardner commented Apr 18, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Here is an example of a dry run from my repository. https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/8744376977/job/23997086869

Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31588

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

@Michael-Gardner Michael-Gardner force-pushed the HPCC-31588-jfrog-cleanup branch from 0f24678 to eb0afcf Compare April 18, 2024 21:19
@Michael-Gardner
Copy link
Contributor Author

Michael-Gardner commented Apr 18, 2024

@ghalliday If these rules look good for you, I'd like to manually run the workflow to do a final test (and the first major deletion) before we merge. Just to double check that deleting a lot of objects at once isn't going to cause an issue.

Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Some minor suggestions....

.github/workflows/cleanup-artifacts.yml Show resolved Hide resolved
.github/workflows/cleanup-artifacts.yml Show resolved Hide resolved
.github/workflows/cleanup-artifacts.yml Outdated Show resolved Hide resolved
@Michael-Gardner Michael-Gardner force-pushed the HPCC-31588-jfrog-cleanup branch 2 times, most recently from 202c68a to 2db18c6 Compare April 19, 2024 12:50
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
A couple of comments. I have also reached out to see what effect this will have on other teams, before merging and removing lots of old versions.

.github/workflows/cleanup-artifacts.yml Show resolved Hide resolved
.github/workflows/cleanup-artifacts.yml Show resolved Hide resolved
@Michael-Gardner Michael-Gardner force-pushed the HPCC-31588-jfrog-cleanup branch from 2db18c6 to d8f6c4f Compare April 22, 2024 19:03
@Michael-Gardner
Copy link
Contributor Author

@ghalliday Added the comments suggested.

@ghalliday ghalliday merged commit e42e65c into hpcc-systems:master May 10, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants