HPCC-31590 Fix incorrect TZ abbreviation for Chammoro

[dcamper]

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31590

Jirabot Action Result:
Workflow Transition: Merge Pending
Updated PR

[GordonSmith]

@dcamper I didn't check our list of zones, but that may not be a typo: https://www.timeanddate.com/time/zones/ ?

[dcamper]

@dcamper I didn't check our list of zones, but that may not be a typo: https://www.timeanddate.com/time/zones/ ?

It is probably not technically an error -- you can find both ChST and CHST on the net -- but our other notes regarding that abbreviation force our hand:

EXPORT TZDataLayout := RECORD STRING5 tzAbbrev; // Time zone abbreviation; always uppercase; may be duplicated between records INTEGER4 secondsOffset; // Number of seconds east (positive) or west (negative) of UTC SET OF STRING15 locations; // Names of locations that use the given time zone abbreviation END;

If someone follows our comments then ChST won't be findable.

[GordonSmith]

I would defer to what you think is correct so, (you could have both just to be safe?)

[dcamper]

I would defer to what you think is correct so, (you could have both just to be safe?)

Ha. Excellent idea. I've just made that change. Can you recheck, please?

[GordonSmith]

@dcamper should this target 9.4.x?

[dcamper]

We could, but I don't think it is that important. I found it only by accident, while looking at something else.