Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-31212 Add plane name to RemoteDirectory #18292

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

wangkx
Copy link
Member

@wangkx wangkx commented Feb 9, 2024

The STD.File.RemoteDirectory lists files in one landing zone folder. The existing method can only specify a landing zone using host name. In this PR, a landing zone can be specified by plane name.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Copy link

github-actions bot commented Feb 9, 2024

@wangkx wangkx requested a review from jakesmith February 9, 2024 21:16
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See general comments in dependent PR (#18275).
Let's revisit this when that review is complete/near complete.

@wangkx wangkx force-pushed the h31212 branch 2 times, most recently from 1d9ed27 to e3100fa Compare February 20, 2024 19:12
@wangkx wangkx requested a review from jakesmith February 21, 2024 21:17
@wangkx wangkx force-pushed the h31212 branch 2 times, most recently from cd0ff8d to e9470c7 Compare February 22, 2024 19:22
@wangkx
Copy link
Member Author

wangkx commented Feb 23, 2024

The windows build error seems not related to this PR. The second commit does not need to be reviewed because it is a temporary build fix for the issue in the latest master repo and will be removed before merging.

@wangkx
Copy link
Member Author

wangkx commented Feb 26, 2024

This PR has been rebased to the latest master where the windows build error has been fixed.

Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangkx - given the route of other changes to MoveExternalFile/DeleteExternalFile/CreateExternalDirectory (i.e. adding a plane param), and despite RemoteDirectory not being a great name (and despite me suggesting a new method name be introduced), I think for consistency with other changes, this change should take the same route, i.e. a plane option should be added to RemoteDirectory too, and it and/or the hostname if provided should be validated against dropzone planes.

@wangkx
Copy link
Member Author

wangkx commented Feb 27, 2024

@jakesmith I am not sure I fully understand your requirement. Based on the comment, I will add a fsRemoteDirectory_v2, as I did for MoveExternalFile, etc. Should I keep the new fsListPlaneDirectory in this PR or it is no longer needed?

1. Create new fsListPlaneDirectory which = fsRemoteDirectory +
plane name.
2. Revise implementation to call the same code from both
fsRemoteDirectory and fsListPlaneDirectory.

Revise based on review: Replace the fsListPlaneDirectory with fsRemoteDirectory_v2

Signed-off-by: wangkx <[email protected]>
@wangkx wangkx changed the title HPCC-31212 Add ListPlaneDirectory to fileservices HPCC-31212 Add plane name to RemoteDirectory Feb 27, 2024
@wangkx
Copy link
Member Author

wangkx commented Feb 27, 2024

@jakesmith I made the changes from fsListPlaneDirectory to fsRemoteDirectory_v2. I also modified the PR title and description. Please review.

@wangkx wangkx requested a review from jakesmith February 27, 2024 21:42
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangkx - looks good.

@wangkx
Copy link
Member Author

wangkx commented Mar 4, 2024

@ghalliday please merge this PR.

@ghalliday ghalliday merged commit 77749a8 into hpcc-systems:master Mar 5, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants