Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31202 File permission dialog fails to open #18286

Merged
merged 1 commit into from
Feb 19, 2024
Merged

HPCC-31202 File permission dialog fails to open #18286

merged 1 commit into from
Feb 19, 2024

Conversation

kunalaswani
Copy link
Contributor

@kunalaswani kunalaswani commented Feb 7, 2024 •
edited
Loading

When checking file permissions for file scopes, dialog was not opening. Dialog now opening for users to check permissions.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@kunalaswani kunalaswani requested a review from jeclrsg February 7, 2024 17:08
@kunalaswani
Copy link
Contributor Author

@jeclrsg can you please review, i am having some trouble populating the user and group drop downs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

https://track.hpccsystems.com/browse/HPCC-31202
Jira updated

jeclrsg
jeclrsg reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalaswani I think something like the comment about the React.useEffect where you currently have the fetchUsersAndGroups function will sort out the userOptions and groupOptions you mentioned

esp/src/src-react/components/forms/CheckPermissions.tsx Show resolved Hide resolved
esp/src/src-react/components/forms/CheckPermissions.tsx Outdated Show resolved Hide resolved
@kunalaswani kunalaswani requested a review from jeclrsg February 8, 2024 20:19
@kunalaswani kunalaswani requested a review from jeclrsg February 9, 2024 16:19
@kunalaswani kunalaswani force-pushed the HPCC-31202 branch 2 times, most recently from cb0100c to 455fd9a Compare February 14, 2024 20:01
jeclrsg
jeclrsg requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalaswani Noticed a couple small things that should be changed. Really just one thing, but it's in a couple or three different places

esp/src/src-react/components/forms/CheckPermissions.tsx Outdated Show resolved Hide resolved
esp/src/src-react/components/forms/CheckPermissions.tsx Show resolved Hide resolved
esp/src/src-react/components/forms/CheckPermissions.tsx Outdated Show resolved Hide resolved
esp/src/src-react/components/forms/CheckPermissions.tsx Outdated Show resolved Hide resolved
@kunalaswani kunalaswani requested a review from jeclrsg February 15, 2024 14:32
jeclrsg
jeclrsg approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunalaswani This looks like it would be checking the file permissions correctly. Had a question about whether that error message should be added to the translations file? But I'd approve otherwise

esp/src/src-react/components/forms/CheckPermissions.tsx Outdated
setFilePermissionResponse(response.FilePermissionResponse.UserPermission);
} catch (error) {
logger.error(error);
setErrorMessage("Error occurred while fetching file permissions.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this error message be added to the translation file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i think it should, i will add it to the file.

@ghalliday
Copy link
Member

@kunalaswani seem comment above about translation

@kunalaswani
HPCC-31202 File permission dialog fails to open
fc4316e 
When checking file permissions for file scopes, dialog was not opening.
Dialog now opening for users to check permissions.

Signed-off-by: Kunal Aswani <[email protected]>
@kunalaswani
Copy link
Contributor Author

@ghalliday error message added to translations.

@ghalliday ghalliday merged commit b79f423 into hpcc-systems:candidate-9.4.x Feb 19, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunalaswani @ghalliday @jeclrsg