Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31188 Ensure scopes table display "a" value. #18262

Merged
merged 1 commit into from
Feb 8, 2024
Merged

HPCC-31188 Ensure scopes table display "a" value. #18262

merged 1 commit into from
Feb 8, 2024

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Jan 26, 2024 •
edited
Loading

Temp fix to ensure either "value", "max" or "avg" is displayed for selected columns.

Add TimeLocalExecute to the default list of columns.

Gordon Smith [email protected]

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg January 26, 2024 16:46
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-31188
Jira updated

GordonSmith
GordonSmith commented Jan 26, 2024
View reviewed changes
esp/src/src-react/components/Metrics.tsx Outdated
row.__groupedProps[p]?.Value ||
row.__groupedProps[p]?.Max ||
row.__groupedProps[p]?.Avg ||
"";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ?? from ||. Will need: hpcc-systems/Visualization#4162

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify. Is this something you plan to change in the future? It looks like you have merged that changed now.
Should I merge this, or wait until you modify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - this PR was "ok" but is better with: hpcc-systems/Visualization#4162 (and switching to ??).

Also - I need to add a fix for the sorting (alpha v numeric).

@GordonSmith GordonSmith marked this pull request as draft February 6, 2024 12:21
@GordonSmith GordonSmith force-pushed the HPCC-31188-SCOPES_VALUE branch from 1a2a4a2 to b41987a Compare February 6, 2024 19:04
@GordonSmith GordonSmith requested a review from jeclrsg February 6, 2024 19:04
@GordonSmith GordonSmith marked this pull request as ready for review February 6, 2024 19:05
@GordonSmith GordonSmith force-pushed the HPCC-31188-SCOPES_VALUE branch from b41987a to 9a8671c Compare February 6, 2024 19:07
@GordonSmith
Copy link
Member Author

Closing and re-opening to force test re-run.

@GordonSmith GordonSmith closed this Feb 7, 2024
@GordonSmith GordonSmith reopened this Feb 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

https://track.hpccsystems.com/browse/HPCC-31188
This pull request is already registered

@GordonSmith GordonSmith force-pushed the HPCC-31188-SCOPES_VALUE branch 2 times, most recently from 3355471 to 6dc20f4 Compare February 8, 2024 13:19
@GordonSmith
HPCC-31188 Ensure scopes table display "a" value.
8ca33a3 
Temp fix to ensure either "value", "max" or "avg" is displayed for
selected columns.

Add TimeLocalExecute to the default list of columns.
Fix sorting to use raw values

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-31188-SCOPES_VALUE branch from 6dc20f4 to 8ca33a3 Compare February 8, 2024 13:23
@GordonSmith
Copy link
Member Author

Closing and re-opening to force re-test

@GordonSmith GordonSmith closed this Feb 8, 2024
@GordonSmith GordonSmith deleted the HPCC-31188-SCOPES_VALUE branch February 8, 2024 14:11
@GordonSmith GordonSmith restored the HPCC-31188-SCOPES_VALUE branch February 8, 2024 14:14
@GordonSmith GordonSmith reopened this Feb 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

https://track.hpccsystems.com/browse/HPCC-31188
This pull request is already registered

@GordonSmith GordonSmith merged commit 3efc2d9 into hpcc-systems:candidate-9.2.x Feb 8, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday left review comments

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GordonSmith @ghalliday @jeclrsg