Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31159 ECL Watch v9 fix file rename issue #18250

Merged
merged 1 commit into from
Feb 6, 2024
Merged

HPCC-31159 ECL Watch v9 fix file rename issue #18250

merged 1 commit into from
Feb 6, 2024

Conversation

jeclrsg
Copy link
Contributor

@jeclrsg jeclrsg commented Jan 24, 2024

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@jeclrsg jeclrsg requested a review from GordonSmith January 24, 2024 17:33
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-31159
Jira updated

@jeclrsg jeclrsg force-pushed the hpcc-31159-rename-file branch from f8c77a4 to 70ce7b4 Compare January 25, 2024 17:02
@jeclrsg jeclrsg requested a review from GordonSmith January 25, 2024 17:03
GordonSmith
GordonSmith reviewed Jan 26, 2024
View reviewed changes
esp/src/src-react/components/forms/RenameFile.tsx Outdated
const getDfuWuRequests = [];

if (logicalFiles?.length === 1) {
const request = { ...data, srcname: logicalFiles[0], DFUServerQueue: "" };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is data.targetRenameFile an array or a string here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was undefined. I don't recall why, but if there was one file the input was named dstname, and if there was a list, it used the targetRenameFile array. It only uses the targetRenameFile array now.

GordonSmith
GordonSmith reviewed Jan 26, 2024
View reviewed changes
esp/src/src-react/components/forms/RenameFile.tsx Outdated
} else if (ID) {
window.setTimeout(function () { window.open(`#/dfuworkunits/${ID}`); }, 0);
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if / else has different logic for error handling? Could be combined to a single flow with the exception of the window.open and pushUrl?

GordonSmith
GordonSmith requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename logic and error handling looks different for the case when there is 1 v many renames?

@jeclrsg jeclrsg force-pushed the hpcc-31159-rename-file branch from 70ce7b4 to e49bed7 Compare January 26, 2024 15:32
@jeclrsg jeclrsg force-pushed the hpcc-31159-rename-file branch from e49bed7 to e888ca1 Compare January 26, 2024 15:39
@GordonSmith GordonSmith merged commit 432b00b into hpcc-systems:candidate-9.2.x Feb 6, 2024
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeclrsg @GordonSmith