-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-30874 Document ensure option on dfuplus & std.file.copy #18126
HPCC-30874 Document ensure option on dfuplus & std.file.copy #18126
Conversation
https://track.hpccsystems.com/browse/HPCC-30874 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesDeFabia please see my questions.
role="bold">]);</emphasis></para> | ||
role="bold">] <emphasis role="bold">[</emphasis> | ||
<emphasis>,ensure</emphasis> <emphasis | ||
role="bold">]);</emphasis></emphasis></para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious for line 31 to 33. Will it be better if changing to:
role="bold">] [</emphasis>
<emphasis>,ensure</emphasis> <emphasis
role="bold">]);</emphasis></para>
role="bold">]);</emphasis></para> | ||
role="bold">] <emphasis role="bold">[</emphasis> | ||
<emphasis>,ensure</emphasis> <emphasis | ||
role="bold">]);</emphasis></emphasis></para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here?
Signed-off-by: Jim DeFabia <[email protected]>
56912ee
to
53105f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JamesDeFabia, looks good.
Type of change:
Checklist:
Smoketest:
Testing: