Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30964 Add overflow support to metrics breadcrumbs #18115

Merged
merged 1 commit into from
Dec 7, 2023
Merged

HPCC-30964 Add overflow support to metrics breadcrumbs #18115

merged 1 commit into from
Dec 7, 2023

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Dec 6, 2023 •
edited
Loading

Remove activity and child from breadcrumbs

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg December 6, 2023 12:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

https://track.hpccsystems.com/browse/HPCC-30964
Jira updated

jeclrsg
jeclrsg requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith looked good to me. One minor comment & GH Actions lint was failing on a missing semicolon in OverflowBreadcrumb.tsx (line 28).

esp/src/src-react/components/controls/OverflowBreadcrumb.tsx Outdated

const overflowItems = React.useMemo(() => {
return breadcrumbs.map((breadcrumb, idx) => <>
<OverflowItem id={breadcrumb.id} groupId={breadcrumb.id} key={`button-items-${breadcrumb.id}`} priority={breadcrumb.id === selected ? 1 : 1}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe no need for the ternary on priority, if always 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I meant to remove that.

@GordonSmith
Copy link
Member Author

Lint issue

@GordonSmith GordonSmith force-pushed the HPCC-30964-METRIC_BREADCUMP_OVERLAP branch from 27a3e7f to 235b331 Compare December 6, 2023 14:42
@GordonSmith
HPCC-30964 Add overflow support to metrics breadcrumbs
e21a818 
Remove activity and child from breadcrumbs

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-30964-METRIC_BREADCUMP_OVERLAP branch from 235b331 to e21a818 Compare December 6, 2023 14:43
@GordonSmith GordonSmith merged commit aeb6cf2 into hpcc-systems:candidate-9.2.x Dec 7, 2023
50 checks passed
@GordonSmith GordonSmith deleted the HPCC-30964-METRIC_BREADCUMP_OVERLAP branch December 7, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg