Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30937 Update readCost, writeCost, numDiskReads and numDiskWrites periodically #18110

Merged
merged 1 commit into from
Jan 25, 2024
Merged

HPCC-30937 Update readCost, writeCost, numDiskReads and numDiskWrites periodically #18110

merged 1 commit into from
Jan 25, 2024

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Dec 5, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

https://track.hpccsystems.com/browse/HPCC-30937
Jira updated

@shamser shamser force-pushed the issue30937 branch 3 times, most recently from dc35fb7 to c6433d3 Compare December 7, 2023 14:10
@shamser shamser requested a review from jakesmith December 7, 2023 14:39
@shamser shamser changed the title HPCC-30937 Update CMasterActivity::diskAccessCost intermittantly HPCC-30937 Update diskAccessCost periodically Dec 7, 2023
@shamser shamser marked this pull request as ready for review December 7, 2023 14:39
jakesmith
jakesmith reviewed Dec 8, 2023
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser please rebase.

@shamser shamser force-pushed the issue30937 branch 3 times, most recently from 5c392de to d50ad91 Compare December 21, 2023 14:01
@shamser shamser changed the title HPCC-30937 Update diskAccessCost periodically HPCC-30937 Update readCost, writeCost, numDiskReads and numDiskWrites periodically Dec 21, 2023
@shamser shamser requested a review from jakesmith December 21, 2023 14:03
jakesmith
jakesmith reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good, a couple of 'future' comments/questions, and it will need rebasing.

dali/base/dadfs.cpp Outdated
return 0;
cost_type writeCost = 0;
ForEachItemIn(idx, clusters)
writeCost += money2cost_type(calcFileAccessCost(clusters.item(idx), numDiskWrites, 0));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need rebasing when cost_type consistency PR merged

thorlcr/activities/thdiskbase.cpp
void CDiskReadMasterBase::done()
{
updateFileReadCostStats();
diskAccessCost = calcFileReadCostStats(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long run, we should be publishing all stats. periodically, i.e. also publishing the file access stats as a Thor subgraph is running, not just at the end.

And it would be okay to do so now for longer running subgraphs, but it could be painful for frequent short running subgraphs.

This is related to https://track.hpccsystems.com/browse/HPCC-29207.
We will need to revisit this/other areas which delay updates like this when HPCC-29207 is worked on.

thorlcr/activities/fetch/thfetch.cpp
CMasterActivity::getActivityStats(stats);
diskAccessCost = calcFileReadCostStats(false);
if (diskAccessCost)
stats.addStatistic(StCostFileAccess, diskAccessCost);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future: instead of aggregating storing (diskAccessCost) as a member, and aggregating in CMasterGraph::getDiskAccessCost(), could the StatisticsAggregator which currently stops at the sg level, be responsible for aggregating these up, so done in a generalized way instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be. I think there are other activity stats that can be aggregated by StatisticsAggregator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - can you open a cost 2.0 subtask to remember to revisit this?

@shamser
HPCC-30937 Update readCost, writeCost, numDiskReads and numDiskWrites…
8198608 
… periodically

Previously, readCost, writeCost, numDiskReads and numDiskWrites was
updated to the workunit at the end of the activity.  This meant that
users were unable to view these stats while the activity was running.
Furthermore, as these costs were calculated at the activity, the
guillotine was also not always effective until the end of an activity
(i.e activities that used a lot of disk access to exceed the guillotine
threshold substantially before being terminated.)

This commit updates readCost, writeCost, numDiskReads and numDiskWrites
periodically (with every serialization of the stats to master).  The
updates to file properties will still be updated at the end of the
activity to avoid creating extra load on dali.

Signed-off-by: Shamser Ahmed <[email protected]>
@shamser shamser requested a review from jakesmith January 16, 2024 13:10
jakesmith
jakesmith approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@jakesmith jakesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamser - looks good.

@ghalliday ghalliday merged commit 7787e78 into hpcc-systems:candidate-9.4.x Jan 25, 2024
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamser @jakesmith @ghalliday