Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30921 Improve Graph Rendering Root #18087

Merged
merged 1 commit into from
Nov 30, 2023
Merged

HPCC-30921 Improve Graph Rendering Root #18087

merged 1 commit into from
Nov 30, 2023

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Nov 28, 2023 •
edited
Loading

  • Add breadcrumbs for graph lineage
  • Don't render parent for select subgraphs
  • Add status spinner with node count

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg November 28, 2023 13:01
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30921
Jira updated

jeclrsg
jeclrsg requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith looked good, just a couple questions & saw some commented out code in there

esp/src/src-react/components/Metrics.tsx Outdated Show resolved Hide resolved
esp/src/src-react/layouts/HpccJSAdapter.tsx Outdated Show resolved Hide resolved
esp/src/src-react/hooks/metrics.ts Outdated Show resolved Hide resolved
esp/src/src-react/components/Metrics.tsx Show resolved Hide resolved
@GordonSmith GordonSmith force-pushed the HPCC-30921-SUBGRAPH_NOPARENT branch from 4102660 to 9ae2953 Compare November 30, 2023 11:05
@GordonSmith GordonSmith requested a review from jeclrsg November 30, 2023 11:41
jeclrsg
jeclrsg requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith just saw a couple lines of commented out code in some of the new additions.

esp/src/src-react/util/metricGraph.ts Outdated Show resolved Hide resolved
esp/src/src-react/components/Metrics.tsx Show resolved Hide resolved
esp/src/src-react/util/metricGraph.ts Show resolved Hide resolved
@GordonSmith
HPCC-30921 Improve Graph Rendering Root
064b73c 
* Add breadcrumbs for graph lineage
* Don't render parent for selected subgraphs
* Add status spinner with node count

Signed-off-by: Gordon Smith <[email protected]>
@GordonSmith GordonSmith force-pushed the HPCC-30921-SUBGRAPH_NOPARENT branch from 9ae2953 to 064b73c Compare November 30, 2023 16:39
@GordonSmith GordonSmith requested a review from jeclrsg November 30, 2023 16:39
@GordonSmith GordonSmith merged commit 6d24ba3 into hpcc-systems:candidate-9.2.x Nov 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GordonSmith @jeclrsg