Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-30854 Ensure partitioning of KJ parts between workers in k8s #18077

Conversation

jakesmith
Copy link
Member

@jakesmith jakesmith commented Nov 23, 2023

When mapping index parts to workers in containerized, treat all as if locally available, such that they will be round-robined into worker buckets. This will cause (when the default remoteKeyedLookup is true), workers to directly access a partition of the index parts and farm out request of the rest to other workers. The net result is to increase cache locality (both jhtree and within the Linux page cache).

Also make some detailed logging conditional on logging level.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

When mapping index parts to workers in containerized, treat all as
if locally available, such that they will be round-robined into
worker buckets. This will cause (when the default remoteKeyedLookup
is true), workers to directly access a partition of the index parts
and farm out request of the rest to other workers.
The net result is to increase cache locality (both jhtree and within
the Linux page cache).

Also make some detailed logging conditional on logging level.

Signed-off-by: Jake Smith <[email protected]>
@jakesmith jakesmith force-pushed the HPCC-30854-kj-use-remotehandlers branch from b4267fc to b1d0564 Compare November 23, 2023 19:07
@jakesmith jakesmith changed the title HPCC-30854 Ensure partitioning of index between workers in KJ in k8s HPCC-30854 Ensure partitioning of KJ parts between workers in k8s Nov 23, 2023
Copy link

@jakesmith jakesmith requested a review from ghalliday November 23, 2023 19:07
@ghalliday ghalliday merged commit b84d5c3 into hpcc-systems:candidate-9.2.x Nov 27, 2023
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants