Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-30612 Warn user when Platform is too old #18031

Merged
merged 2 commits into from
Nov 23, 2023
Merged

HPCC-30612 Warn user when Platform is too old #18031

merged 2 commits into from
Nov 23, 2023

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Nov 15, 2023 •
edited
Loading

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@GordonSmith GordonSmith requested a review from jeclrsg November 15, 2023 11:28
@github-actions GitHub Actions
Copy link

https://track.hpccsystems.com/browse/HPCC-30612
Jira updated

jeclrsg
jeclrsg requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@jeclrsg jeclrsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith Saw a couple of spots that I wasn't sure if the Dates might be invalid, if stuff was undefined?

esp/src/src-react/hooks/platform.ts Outdated
setPoint(response?.BuildVersionPoint);
setVersion(response?.BuildVersion);
setMaturity(response?.BuildMaturity);
setTimestamp(new Date(response?.BuildTagTimestamp));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be an invalid date if BuildTagTimestamp were undefined

esp/src/eclwatch/HPCCPlatformWidget.js Outdated

const DAY = 1000 * 60 * 60 * 24;
platformModule.fetchCheckFeatures().then(function (features) {
const age = Math.floor((Date.now() - new Date(features.BuildTagTimestamp).getTime()) / DAY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If features didn't come back for some reason, might have an invalid date here also, and a NaN for age.

@GordonSmith GordonSmith force-pushed the HPCC-30612-BEST_BEFORE_WARNING branch from 769732b to d810695 Compare November 16, 2023 17:06
@GordonSmith GordonSmith requested a review from jeclrsg November 16, 2023 17:08
ghalliday
ghalliday reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GordonSmith Looks good. A couple of comments on the message, and one on colouring (can ignore that one).

esp/src/eclwatch/HPCCPlatformWidget.js
const message = nlsHPCC.PlatformIsNNNDaysOld.replace("NNN", `${age}`);
let severity = "Info";
if (age > 90) {
severity = "Alert";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colouring of alerts in the old eclwatch looks less important than errors,

esp/src/src/nls/hpcc.ts Outdated
@@ -639,6 +641,7 @@ export = {
PlaceholderFirstName: "John",
PlaceholderLastName: "Smith",
Platform: "Platform",
PlatformIsNNNDaysOld: "Platform is NNN days old",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest reword to
"Platform build is NNN days old."

Once it is reported as a warning it should be

"Platform build is NNN days old. Please upgrade to a later point release."

to make it clear that it isn't the version we are complaining about, and how to resolve it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly add "(See About/Latest Releases for details.)"

@GordonSmith
Swap alert + error colours for v5 ECL Watch
e9fc442 
Update warning messages
Switch to Alert from Critical in v9 ECL Watch
@GordonSmith
Copy link
Member Author

@ghalliday - updated with (most) of the suggestions.

@GordonSmith GordonSmith requested a review from jeclrsg November 22, 2023 14:16
@ghalliday ghalliday merged commit 9d9c3d9 into hpcc-systems:candidate-8.12.x Nov 23, 2023
23 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeclrsg jeclrsg jeclrsg approved these changes

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GordonSmith @ghalliday @jeclrsg